From 2ecf93d9904544ee73159e9f0ee74b49057bca6c Mon Sep 17 00:00:00 2001
From: Jules Aguillon
Date: Sun, 1 Feb 2026 23:25:38 +0100
Subject: Candidates view improvements (#1168)

* Refactor: Create subpackage 'suggestions'

* Candidates view: Status message when no dictionary installed

Show a message on the candidates view instead of leaving it empty. A
button points to the dictionary installation activity.

* Add an option to disable the suggestions

* Refactor: Remove Config.should_show_candidates_view

This was moved to EditorConfig.

* Don't disable text suggestions in some text boxes

* Suggestion text size matching settings

The candidates view height is based on the height of keyboard rows and
the suggestion text size is based on the size of labels on the keys.

This is influenced by symbol size and keyboard height options.---
 srcs/juloo.keyboard2/CandidatesView.java | 104 -------------------------------
 1 file changed, 104 deletions(-)
 delete mode 100644 srcs/juloo.keyboard2/CandidatesView.java

(limited to 'srcs/juloo.keyboard2/CandidatesView.java')

diff --git a/srcs/juloo.keyboard2/CandidatesView.java b/srcs/juloo.keyboard2/CandidatesView.java
deleted file mode 100644
index 232ed23..0000000
--- a/srcs/juloo.keyboard2/CandidatesView.java
+++ /dev/null
@@ -1,104 +0,0 @@
-package juloo.keyboard2;
-
-import android.content.Context;
-import android.text.InputType;
-import android.util.AttributeSet;
-import android.view.View;
-import android.view.inputmethod.EditorInfo;
-import android.widget.LinearLayout;
-import android.widget.TextView;
-import java.util.ArrayList;
-import java.util.List;
-
-public class CandidatesView extends LinearLayout
-{
-  static final int NUM_CANDIDATES = 3;
-
-  Config _config;
-
-  /** Candidates currently visible. Entries can be [null] when there are less
-      than [NUM_CANDIDATES] suggestions. */
-  String[] _items = new String[NUM_CANDIDATES];
-
-  /** Text views showing the candidates in [_items]. Text views visibility is
-      set to [GONE] when there are less than [NUM_CANDIDATES] suggestions. */
-  TextView[] _item_views = new TextView[NUM_CANDIDATES];
-
-  public CandidatesView(Context context, AttributeSet attrs)
-  {
-    super(context, attrs);
-    _config = Config.globalConfig();
-  }
-
-  @Override
-  protected void onFinishInflate()
-  {
-    super.onFinishInflate();
-    setup_item_view(0, R.id.candidates_middle);
-    setup_item_view(1, R.id.candidates_right);
-    setup_item_view(2, R.id.candidates_left);
-  }
-
-  public void set_candidates(List<String> suggestions)
-  {
-    int s_count = suggestions.size();
-    for (int i = 0; i < _item_views.length; i++)
-    {
-      TextView v = _item_views[i];
-      if (i < s_count)
-      {
-        String it = suggestions.get(i);
-        _items[i] = it;
-        v.setText(it);
-        v.setVisibility(View.VISIBLE);
-      }
-      else
-      {
-        _items[i] = null;
-        v.setVisibility(View.GONE);
-      }
-    }
-  }
-
-  private void setup_item_view(final int item_index, int item_id)
-  {
-    TextView v = (TextView)findViewById(item_id);
-    v.setOnClickListener(new View.OnClickListener()
-        {
-          @Override
-          public void onClick(View _v)
-          {
-            String it = _items[item_index];
-            if (it != null)
-              _config.handler.suggestion_entered(it);
-          }
-        });
-    v.setVisibility(View.GONE);
-    _item_views[item_index] = v;
-  }
-
-  public static boolean should_show(EditorInfo info)
-  {
-    int variation = info.inputType & InputType.TYPE_MASK_VARIATION;
-    int flags = info.inputType & InputType.TYPE_MASK_FLAGS;
-    switch (info.inputType & InputType.TYPE_MASK_CLASS)
-    {
-      case InputType.TYPE_CLASS_TEXT:
-        switch (variation)
-        {
-          case InputType.TYPE_TEXT_VARIATION_PASSWORD:
-          case InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD:
-          case InputType.TYPE_TEXT_VARIATION_WEB_PASSWORD:
-            return false;
-          default:
-            if ((flags & InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS) != 0)
-              return false; // Editor requested that we don't show suggestions
-            return true;
-        }
-      case InputType.TYPE_CLASS_NUMBER:
-        // Beware of TYPE_NUMBER_VARIATION_PASSWORD
-        return false;
-      default: return false;
-    }
-  }
-}
-- 
cgit v1.2.3