From 0549c6c8a116b416769d85e33967cd4d70fd46ee Mon Sep 17 00:00:00 2001 From: Jules Aguillon Date: Sat, 16 Mar 2024 23:42:37 +0100 Subject: Fix potential out of bounds access The preferred pos mechanism could cause an out of bounds access on 1 row layouts. --- srcs/juloo.keyboard2/KeyboardData.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/srcs/juloo.keyboard2/KeyboardData.java b/srcs/juloo.keyboard2/KeyboardData.java index af432b7..c8dcd13 100644 --- a/srcs/juloo.keyboard2/KeyboardData.java +++ b/srcs/juloo.keyboard2/KeyboardData.java @@ -82,7 +82,7 @@ public final class KeyboardData boolean add_key_to_pos(List rows, KeyValue kv, KeyPos p) { int i_row = p.row; - int i_row_end = p.row; + int i_row_end = Math.min(p.row, rows.size()); if (p.row == -1) { i_row = 0; i_row_end = rows.size() - 1; } for (; i_row <= i_row_end; i_row++) { -- cgit v1.2.3