From dac702ad0b1332cc549aeb0c620f72cb4c4a4a1b Mon Sep 17 00:00:00 2001
From: Jules Aguillon
Date: Sun, 18 Feb 2024 17:55:41 +0100
Subject: CI: Improve layout and store description checks (#565)

* CI: Run 'check_layout.py'

Ensures that 'check_layout.output' is not outdated.
Also, update it.

* CI: Check new store descriptions

When a store description is added, 'python3 sync_translations.py' leaves
an untracked file that is not checked.

This makes sure that untracked store descriptions are noticed in CI.---
 .github/workflows/check-layouts.yml      | 17 ++++++++++++-----
 .github/workflows/check-translations.yml |  4 ++--
 2 files changed, 14 insertions(+), 7 deletions(-)

(limited to '.github')

diff --git a/.github/workflows/check-layouts.yml b/.github/workflows/check-layouts.yml
index d37af40..49d85a2 100644
--- a/.github/workflows/check-layouts.yml
+++ b/.github/workflows/check-layouts.yml
@@ -1,19 +1,26 @@
 name: Check layouts
 
-# Runs 'gen_layouts.py' and checks that the generated file were uptodate.
-# This doesn't run 'check_layout.py'.
-
 on:
   workflow_dispatch:
   push:
   pull_request:
 
 jobs:
-  check-layouts:
+  gen-layouts:
+    name: Generated files
     runs-on: ubuntu-latest
     steps:
     - name: Checkout repo
       uses: actions/checkout@v4
     - run: python3 gen_layouts.py
-    - name: Check that the generated layouts.xml is uptodate, run python3 gen_layouts.py otherwise
+    - name: "Check that the generated 'layouts.xml' is uptodate, otherwise run 'python3 gen_layouts.py'"
+      run: git diff --exit-code
+  check-layouts:
+    name: check_layout.output
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout repo
+      uses: actions/checkout@v4
+    - run: python3 check_layout.py
+    - name: "Check that the generated 'check_layout.output' is uptodate, otherwise run 'python3 check_layout.py'"
       run: git diff --exit-code
diff --git a/.github/workflows/check-translations.yml b/.github/workflows/check-translations.yml
index c06ca23..db30a29 100644
--- a/.github/workflows/check-translations.yml
+++ b/.github/workflows/check-translations.yml
@@ -12,5 +12,5 @@ jobs:
     - name: Checkout repo
       uses: actions/checkout@v4
     - run: python3 sync_translations.py
-    - name: Check that strings files are uptodate, run python3 sync_translations.py otherwise
-      run: git diff --exit-code
+    - name: "Check that strings files are uptodate, otherwise run 'python3 sync_translations.py'"
+      run: git add -N . && git diff --exit-code
-- 
cgit v1.2.3